1. 将线索状态机坍缩为深模块
Strong
in-process
Files
crm-lead/.../service/impl/LeadServiceImpl.java (738 行)
crm-lead/.../job/LeadRecycleJob.java
crm-lead/.../job/LeadExpireJob.java
crm-lead/.../event/PoolChangedEventListener.java
crm-lead/.../service/impl/LeadServiceImpl.java (738 行)
crm-lead/.../job/LeadRecycleJob.java
crm-lead/.../job/LeadExpireJob.java
crm-lead/.../event/PoolChangedEventListener.java
Before — 状态机散落 9 处
flowchart TD
subgraph SVC["LeadServiceImpl (738行)"]
CL["claimLead()"] --> CAS1["casUpdate()"]
AS["assignToPool()"] --> CAS1
AU["assignToUser()"] --> CAS2["inline CAS"]
FB["submitFeedback()"] --> CAS2
CV["convertToOpportunity()"] --> CAS1
RL["releaseLead()"] --> CAS1
AC["activateLead()"] --> CAS2
end
subgraph JOB["定时任务 (绕过 service)"]
RJ["LeadRecycleJob"] --> MAGIC1["magic: status IN 3,4"]
EJ["LeadExpireJob"] --> MAGIC2["magic: NOT IN 5,6"]
end
CAS1 --> DB[(lead table)]
CAS2 --> DB
MAGIC1 --> DB
MAGIC2 --> DB
style CAS2 fill:#fef3c7
style MAGIC1 fill:#fecaca
style MAGIC2 fill:#fecaca
style SVC fill:#f8fafc
style JOB fill:#fff7ed
- • 7 方法各自 if-else 校验状态、构建 wrapper
- • 2 Job 绕过 service，用魔法数字硬编码状态
- • CAS 调用不一致：4 处用 casUpdate()，3 处内联
After — 一个深模块收拢全部迁移
flowchart TD
subgraph SVC["LeadServiceImpl (瘦身)"]
CL["claimLead()"]
FB["submitFeedback()"]
RL["releaseLead()"]
OTHER["...其他方法"]
end
subgraph SM["LeadTransition (深模块)"]
RULES["迁移规则表\n(from, action) to (to, sideEffects)"]
EXEC["execute(leadId, action, ctx)\nCAS + side-effects + history"]
end
subgraph JOB["定时任务"]
RJ["LeadRecycleJob"]
EJ["LeadExpireJob"]
end
CL --> SM
FB --> SM
RL --> SM
OTHER --> SM
RJ --> SM
EJ --> SM
EXEC --> DB[(lead table)]
style SM fill:#0f172a,color:#e2e8f0
style RULES fill:#1e293b,color:#e2e8f0
style EXEC fill:#1e293b,color:#e2e8f0
- • 9 个调用点 to 1 个 interface
- • 状态规则集中声明，魔法数字消除
- • 纯逻辑可零 mock 测试
Problem
7 态状态机的迁移规则隐式散落在 7 个 service 方法 + 2 个定时任务中。理解"从已领取能走到哪"需要读 5 个方法。Job 用魔法数字 3,4 替代 STATUS_CLAIMED。CAS 调用方式不统一——4 处走 casUpdate() helper，3 处内联 baseMapper.update()。
Solution
提取 LeadTransition 深模块：声明全部 (from, action) to (to, sideEffects) 规则，暴露 execute(leadId, action) 一个方法做 CAS + 副作用 + history。Service 和 Job 都调它。
Wins
locality: 迁移 bug 集中到一个模块
leverage: 9 调用点 to 1 interface
interface 缩窄；implementation 吸收 wrapper
零 mock 测试迁移规则
消除魔法数字