crm-backend-matt/.scratch/review_diff_sdl_test.txt

��diff --git a/crm-auth/src/test/java/com/crm/auth/service/impl/AuthServiceImplTest.java b/crm-auth/src/test/java/com/crm/auth/service/impl/AuthServiceImplTest.java
index bc6bd6d..7eafe96 100644
--- a/crm-auth/src/test/java/com/crm/auth/service/impl/AuthServiceImplTest.java
+++ b/crm-auth/src/test/java/com/crm/auth/service/impl/AuthServiceImplTest.java
@@ -5,8 +5,10 @@ import com.crm.auth.domain.dto.LoginResultDTO;
 import com.crm.auth.domain.dto.UserInfoDTO;
 import com.crm.auth.domain.entity.AuthIdentity;
 import com.crm.auth.domain.entity.AuthUser;
+import com.crm.auth.domain.enums.ClientTypeEnum;
 import com.crm.auth.domain.enums.IdentityTypeEnum;
 import com.crm.auth.security.AuthLoginUser;
+import com.crm.auth.security.PreLoginSession;
 import com.crm.auth.security.TokenService;
 import com.crm.auth.service.IAuthIdentityService;
 import com.crm.auth.service.IAuthUserService;
@@ -21,6 +23,7 @@ import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.ArgumentCaptor;
+import org.mockito.InOrder;
 import org.mockito.InjectMocks;
 import org.mockito.MockedStatic;
 import org.mockito.Mock;
@@ -36,6 +39,7 @@ import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoInteractions;
 import static org.mockito.Mockito.when;
 
 /**
@@ -99,10 +103,10 @@ class AuthServiceImplTest {
         when(authIdentityService.getByTypeAndUnionId(TYPE, "union-001")).thenReturn(identity);
         when(authUserService.getById(1001L)).thenReturn(user);
 
-        LoginResultDTO result = authService.login(TYPE, AUTH_CODE);
+        LoginResultDTO result = authService.login(TYPE, AUTH_CODE, null);
 
+        assertThat(result.getStatus()).isEqualTo(LoginResultDTO.LoginStatus.SUCCESS);
         assertThat(result.getToken()).isEqualTo(TOKEN);
-        assertThat(result.getUserInfo()).isNotNull();
         assertThat(result.getUserInfo().getId()).isEqualTo(1001L);
         assertThat(result.getUserInfo().getUsername()).isEqualTo("p�zOde��?);
 
@@ -129,6 +133,8 @@ class AuthServiceImplTest {
         assertThat(loginUser.getUsername()).isEqualTo("p�zOde��?);
         assertThat(loginUser.getMobile()).isEqualTo("13800000000");
         assertThat(loginUser.getAvatar()).isEqualTo(user.getAvatar());
+        // �m�]6} clientType �i?j{� PC��\�j0��f� yO�`/u>�l��~��7pn�m=_Z� b�P�[�fZ"�?+        assertThat(loginUser.getClientType()).isEqualTo(ClientTypeEnum.PC);
     }
 
     @Test
@@ -140,7 +146,7 @@ class AuthServiceImplTest {
         when(authIdentityService.getByTypeAndUnionId(TYPE, "union-001")).thenReturn(null);
         when(authUserService.getByMobile("13800000000")).thenReturn(existing);
 
-        LoginResultDTO result = authService.login(TYPE, AUTH_CODE);
+        LoginResultDTO result = authService.login(TYPE, AUTH_CODE, null);
 
         assertThat(result.getToken()).isEqualTo(TOKEN);
         assertThat(result.getUserInfo().getId()).isEqualTo(2002L);
@@ -167,7 +173,7 @@ class AuthServiceImplTest {
             return true;
         }).when(authUserService).save(any(AuthUser.class));
 
-        LoginResultDTO result = authService.login(TYPE, AUTH_CODE);
+        LoginResultDTO result = authService.login(TYPE, AUTH_CODE, null);
 
         assertThat(result.getToken()).isEqualTo(TOKEN);
         assertThat(result.getUserInfo().getId()).isEqualTo(3003L);
@@ -194,7 +200,7 @@ class AuthServiceImplTest {
         when(authUserService.getByMobile("13800000000")).thenReturn(null);
         when(thirdPartyClient.isOrgMember(thirdUser)).thenReturn(false);
 
-        assertThatThrownBy(() -> authService.login(TYPE, AUTH_CODE))
+        assertThatThrownBy(() -> authService.login(TYPE, AUTH_CODE, null))
                 .isInstanceOf(BusinessErrorException.class)
                 .hasFieldOrPropertyWithValue("code", AuthConstants.CODE_NOT_ORG_MEMBER);
 
@@ -217,7 +223,7 @@ class AuthServiceImplTest {
             return true;
         }).when(authUserService).save(any(AuthUser.class));
 
-        authService.login(TYPE, AUTH_CODE);
+        authService.login(TYPE, AUTH_CODE, null);
 
         verify(authUserService, never()).getByMobile(anyString());
         verify(authUserService).save(any(AuthUser.class));
@@ -237,7 +243,7 @@ class AuthServiceImplTest {
         when(authIdentityService.getByTypeAndUnionId(TYPE, "union-001")).thenReturn(identity);
         when(authUserService.getById(5005L)).thenReturn(user);
 
-        assertThatThrownBy(() -> authService.login(TYPE, AUTH_CODE))
+        assertThatThrownBy(() -> authService.login(TYPE, AUTH_CODE, null))
                 .isInstanceOf(BusinessErrorException.class)
                 .hasFieldOrPropertyWithValue("code", AuthConstants.CODE_USER_DISABLED);
 
@@ -263,7 +269,7 @@ class AuthServiceImplTest {
             return true;
         }).when(authUserService).save(any(AuthUser.class));
 
-        authService.login(TYPE, AUTH_CODE);
+        authService.login(TYPE, AUTH_CODE, null);
 
         // ȓG��v"�?bind�UWdentity �[�c�tf���}
         verify(authIdentityService, never()).bind(any(), any(), any());
@@ -307,6 +313,110 @@ class AuthServiceImplTest {
         }
     }
 
+    @Test
+    @DisplayName("�t?("�&1�W, �~? �[�SAn2Z��0}�t?-> �m�]7��YE�!} token��\Q~e�?DEVICE_ONLINE + preLoginToken�X�|R�?lastLoginTime�?)
+    void login_whenDeviceOnline_returnsDeviceOnlineWithPreLoginToken() {
+        when(clientFactory.getClient(TYPE)).thenReturn(thirdPartyClient);
+        when(thirdPartyClient.getUserInfo(AUTH_CODE)).thenReturn(thirdUser);
+
+        AuthIdentity identity = new AuthIdentity();
+        identity.setId(9001L);
+        identity.setUserId(1001L);
+        AuthUser user = buildUser(1001L, "p�zOde��?, "13800000000", true);
+        when(authIdentityService.getByTypeAndUnionId(TYPE, "union-001")).thenReturn(identity);
+        when(authUserService.getById(1001L)).thenReturn(user);
+        when(tokenService.isOnline("1001", ClientTypeEnum.PC)).thenReturn(true);
+        when(tokenService.createPreLoginToken("1001", ClientTypeEnum.PC)).thenReturn("plt-001");
+
+        LoginResultDTO result = authService.login(TYPE, AUTH_CODE, null);
+
+        assertThat(result.getStatus()).isEqualTo(LoginResultDTO.LoginStatus.DEVICE_ONLINE);
+        assertThat(result.getPreLoginToken()).isEqualTo("plt-001");
+        assertThat(result.getToken()).isNull();
+        assertThat(result.getUserInfo()).isNull();
+
+        verify(tokenService, never()).createToken(any());
+        // P�,�Js�m�q�W lastLoginTime�%X� Y
0 Y�?+        verify(authUserService).updateById(any(AuthUser.class));
+    }
+
+    @Test
+    @DisplayName("clientType=Mobile�XG0Op�_SU�m�]qf���q}-> Y�E��[ MOBILE �~���4Z)[{�~�`B_�|\	{�~?PC �~?)
+    void login_whenClientTypeMobile_detectsAndIssuesOnMobileOnly() {
+        stubThirdPartyHappyPath();
+        stubLocatedUser(1001L);
+
+        LoginResultDTO result = authService.login(TYPE, AUTH_CODE, "Mobile");
+
+        assertThat(result.getStatus()).isEqualTo(LoginResultDTO.LoginStatus.SUCCESS);
+        verify(tokenService).isOnline("1001", ClientTypeEnum.MOBILE);
+        verify(tokenService, never()).isOnline(anyString(), eq(ClientTypeEnum.PC));
+
+        ArgumentCaptor<AuthLoginUser> loginUserCap = ArgumentCaptor.forClass(AuthLoginUser.class);
+        verify(tokenService).createToken(loginUserCap.capture());
+        assertThat(loginUserCap.getValue().getClientType()).isEqualTo(ClientTypeEnum.MOBILE);
+    }
+
+    @Test
+    @DisplayName("clientType ē�r�v�m�]�W -> ��?61016��[ail-fast �m�]S^��?authCode")
+    void login_whenClientTypeUnsupported_throwsEarly() {
+        assertThatThrownBy(() -> authService.login(TYPE, AUTH_CODE, "tv"))
+                .isInstanceOf(BusinessErrorException.class)
+                .hasFieldOrPropertyWithValue("code", AuthConstants.CODE_UNSUPPORTED_CLIENT_TYPE);
+
+        verifyNoInteractions(clientFactory, tokenService, authUserService, authIdentityService);
+    }
+
+    @Test
+    @DisplayName("confirmLogin�-l�y�t?preLoginToken -> O�#X�mÓB0}�t�o@U�~�p�g token�X+u�~⫈h�6[}-> SUCCESS")
+    void confirmLogin_kicksOldAndIssuesNew() {
+        PreLoginSession pre = new PreLoginSession();
+        pre.setUserId("1001");
+        pre.setClientType("pc");
+        when(tokenService.consumePreLoginToken("plt-001")).thenReturn(pre);
+        when(authUserService.getByIdOrThrow("1001")).thenReturn(buildUser(1001L, "p�zOde��?, "13800000000", true));
+        when(tokenService.createToken(any(AuthLoginUser.class))).thenReturn(TOKEN);
+
+        LoginResultDTO result = authService.confirmLogin("plt-001");
+
+        assertThat(result.getStatus()).isEqualTo(LoginResultDTO.LoginStatus.SUCCESS);
+        assertThat(result.getToken()).isEqualTo(TOKEN);
+        assertThat(result.getPreLoginToken()).isNull();
+        assertThat(result.getUserInfo().getId()).isEqualTo(1001L);
+
+        // $i�T-|�,l�S��!2�hP��]7�“.^}��!2�h\m�U�h�o��}�~�p�h\m�U0}��EZ�V�[���m��Y}
+        InOrder inOrder = Mockito.inOrder(tokenService);
+        inOrder.verify(tokenService).kickSession("1001", ClientTypeEnum.PC);
+        inOrder.verify(tokenService).createToken(any(AuthLoginUser.class));
+
+        ArgumentCaptor<AuthLoginUser> loginUserCap = ArgumentCaptor.forClass(AuthLoginUser.class);
+        verify(tokenService).createToken(loginUserCap.capture());
+        assertThat(loginUserCap.getValue().getClientType()).isEqualTo(ClientTypeEnum.PC);
+        assertThat(loginUserCap.getValue().getUserId()).isEqualTo("1001");
+    }
+
+    @Test
+    @DisplayName("confirmLogin�qkreLoginToken ig�Van/�[�S�y�t?|mH�� ?-> 
�q�z��?61014�|\	{��m�	{�~?)
+    void confirmLogin_whenPreloginInvalid_throws() {
+        when(tokenService.consumePreLoginToken("plt-gone")).thenReturn(null);
+
+        assertThatThrownBy(() -> authService.confirmLogin("plt-gone"))
+                .isInstanceOf(BusinessErrorException.class)
+                .hasFieldOrPropertyWithValue("code", AuthConstants.CODE_PRELOGIN_INVALID);
+
+        verify(tokenService, never()).kickSession(anyString(), any());
+        verify(tokenService, never()).createToken(any());
+        verifyNoInteractions(authUserService);
+    }
+
+    private void stubLocatedUser(Long userId) {
+        AuthIdentity identity = new AuthIdentity();
+        identity.setId(9000L);
+        identity.setUserId(userId);
+        when(authIdentityService.getByTypeAndUnionId(TYPE, "union-001")).thenReturn(identity);
+        when(authUserService.getById(userId)).thenReturn(buildUser(userId, "p�zOde��?, "13800000000", true));
+    }
+
     private AuthUser buildUser(Long id, String username, String mobile, boolean enabled) {
         AuthUser user = new AuthUser();
         user.setId(id);